Skip to content

Example code in ReadMe won't run. #76

Open
@Julian-O

Description

The Readme contains some example code.

One example demonstrates that servers are also clients:

  • It imports time.sleep() but never uses it. Meanwhile, it uses time.time() without importing it.
  • It has a variable called cont which is never defined.
  • It does a busy wait, which is not demonstrating a good way to use the API.
  • It keeps appending True to a list (Why not just count?), but never popping it.
  • ping takes parameters, but it isn't clear what they represent.
  • pong doesn't use the *parameter. Rename it _.

One example demonstrates that async servers.

  • It imports OSCThreadServer but uses OSCAsyncServer

One example demonstrates how Unicode is used.

  • Uses OSCThreadServer without importing.
  • Uses send_message() without the expected osc. prefix.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions