Open
Description
The Readme contains some example code.
One example demonstrates that servers are also clients:
- It imports
time.sleep()
but never uses it. Meanwhile, it usestime.time()
without importing it. - It has a variable called
cont
which is never defined. - It does a busy wait, which is not demonstrating a good way to use the API.
- It keeps appending True to a list (Why not just count?), but never popping it.
- ping takes parameters, but it isn't clear what they represent.
- pong doesn't use the *parameter. Rename it
_
.
One example demonstrates that async servers.
- It imports OSCThreadServer but uses OSCAsyncServer
One example demonstrates how Unicode is used.
- Uses OSCThreadServer without importing.
- Uses send_message() without the expected
osc.
prefix.
Metadata
Assignees
Labels
No labels
Activity