Skip to content

Don't show the "Unknown/unsupported 'ghc' version detected" warning at default verbosity #9734

Open
@Mikolaj

Description

Here's the warning

-- Cabal currently supports ghc >= 7.0.1 && < 9.10
-- ... and the following odd development version
unless (ghcVersion < mkVersion [9, 10]) $
warn verbosity $
"Unknown/unsupported 'ghc' version detected "
++ "(Cabal "
++ prettyShow cabalVersion
++ " supports 'ghc' version < 9.10): "
++ programPath ghcProg
++ " is version "
++ prettyShow ghcVersion

The rationale is that our release sync method with GHC releases has changed and now Cabal is supposed to release a new version before GHC releases theirs and so we can't easily test that the new GHC works fine with the new cabal release. What we and the fine GHC folk can do is analyse the API and make the best effort and then be on a lookup for problems. That makes this warning much weaker than it was before (or rather, the lack of the warning gives much weaker guarantees than if GHC was in CI before the warning is enabled for a given GHC version). So I'd propose to show it only at verbosity one notch higher than the default. We also had a case where we needed to do a lightning fixup release only to silence the warning, because it's so spammy and that's not a good use of cabal maintainer time and sanity.

Thoughts? Related: #9729

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    re: versionAbout the version of the Cabal library and cabal-installre: warningsConcerning warnings printed by cabalreleasetype: RFCRequests for Commenttype: discussion

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions