Skip to content

cabal-validate: Steps change depending on options which choose steps #10565

Open
@9999years

Description

The build step will build... the stuff used by the other steps you're running!

E.g. solver-benchmarks is only built if --solver-benchmarks is passed... but if you use --step solver-benchmarks-run manually, it won't be built. cabal-install-solver will not be built if --lib-only is passed.

So this introduces two confusing behaviors:

  1. ./validate.sh -s build && ./validate.sh -s solver-benchmarks will error because solver-benchmarks aren't built.
  2. ./validate.sh -s build won't catch compile errors in solver-benchmarks, which is a little confusing. ./validate.sh -s build should... build everything that gets tested in CI, I think!

Related:

Proposal: There should be a build group which builds everything, and steps build-lib, build-cli, and build-solver-benchmarks which build specific sets of libraries.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    cabal-validatevalidate.sh (cabal-validate) test suite runnermeta: trackingre: devxImproving the cabal developer experience (internal issue)type: testingIssues about project test suites

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions