Please, pass own test suite inside the Nixpkgs

[Anton-Latukha]

In Nixpkgs hnix currently still needs dontCheck.

When it passes test suite - rm dontCheck in hnix there in Nixpkgs.

[sjakobi]

For reference: https://github.com/NixOS/nixpkgs/blob/1ceecdd109d0c30fd48fc6af295d9c8b05d6c6c6/pkgs/development/haskell-modules/configuration-common.nix#L205-L210.

  # 2020-06-05: HACK: does not passes own build suite - `dontCheck` We should
  # generate optparse-applicative completions for the hnix executable.  Sadly
  # building of the executable has been disabled for ghc < 8.10 in hnix.
  # Generating the completions should be activated again, once we default to
  # ghc 8.10.
  hnix = dontCheck super.hnix;

Does "build suite" refer to nix build BTW?

[Anton-Latukha]

Oh, I meant test suite. I put that message before, like a month ago (2020-06-05).

Well, after 0.9.0 maralorn and I made PRs in parallel, and I saw that his solution is more detailed.

He addressed the GHC 8.10 set in Nixpkgs, so HNix does build with executable and completions for GHC > 8.10 in Nixpkgs distribution.

But I overlooked - he attached his message to the end of mine previous message - and now the overall message is a mess.

The test suite of course passes in our default.nix.
And I remember that there is Nixpkgs problem but already forgot why dontCheck not passing right in Nixpkgs there

Inside Nixpkgs HNix is imported not from our default.nix here, but from Hackage and put directly inside Nixpkgs and that allows test Hydra CI build and run test suite inside it that environment. Basically our configuration and dependencies of our HNix default.nix derivation different to the HNix derivation inside Haskell-Nixpkgs infrastructure, and that is where the detail is.

[Anton-Latukha]

After every release, I go and during my civil duty batch Haskell packages clean-up work I test and sneak-in a proper HNix overrides into Nixpkgs, so that HNix always works there. I to that degree keep our name from popping in Nixpkgs repo, community and in the community talk - to a beyond radar minimum.

[layus]

@expipiplus1 Still pending on #903 to remove network access in the way we use the store. Then I guess it is just a matter of finding the few remaining tests that still use the network (there should be none) and the problem would be solved.