Skip to content

Compression handling uses wrong error codes #1428

Open
@jhump

Description

According to the gRPC docs for compression, when a server sends a response using an unrecognized/unsupported encoding the client MUST report the error with an internal error code. (See bullet 5 in the test cases section of that doc.)

Similarly, when a server sends a message where the envelope has the “compressed” bit set, but there is no encoding for the stream (or the encoding is “identity”), the recipient MUST fail with an internal error code.

The client in this package returns an unknown error in both of these situations instead of internal.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions