Skip to content

Variadic macros cause problems with cpphs #16

Open
@mithrandi

Description

It seems that the variadic macros used in some of the shims cause... issues... with cpphs. Demonstration of the problem:

mithrandi@verdant /tmp> cpphs --cpp -P -C foo -o bar
mithrandi@verdant /tmp> cat foo
#define FOO(args...) f(args)
FOO(1)
FOO(1, 2)
FOO(1, 2, 3)
mithrandi@verdant /tmp> cat bar

FOO(1)
f(1)
FOO(1, 2, 3)

The good news is that there seem to be very few invocations of these macros that actually pass multiple arguments, so I think it should be fairly easy to make these macros non-variadic, which would avoid the problem. Would this be a reasonable solution?

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions