Spack builder (and other compile errors)

[markyoder]

@tjhei :

I had a request for aspect, so of course I turned straight to Spack -- where you have a nice build package, but a few things:

1. I can build aspect@develop without too much (or maybe with none) trouble
2. The available version, up to @2.3.0 fails, as I recall because of updates to dealii; reverting back to an older version of dealii would do the trick, except that I then run into a dealii build error, so I decided to skip it.
3. So I made a fork of the repo and added @2.4.0 and @2.5.0, but I get some compiler errors,

In utilities.cc, in the section on/around:

#ifdef DEAL_II_WITH_MPI
        /**
         * Return the corresponding MPI data type id for the argument given.
         */
        inline MPI_Datatype
        mpi_type_id(const bool *)
        {
        return MPI_CXX_BOOL;

It looks like these may be related to changes in DEALII (namely, maybe the DEAL_II_WITH_MPI variable is not being set any longer?)

Then, if I work around that, by just hard coding the MPI>2.x option, I get some linking errors -- which I think is a libpng vs zlib thing.

So my question is, before I dig into updating this an putting in a PR, do you have any plans to update that Spack recipe, and maybe a new release (@develop is at v3.1.0 I believe). I'm happy to contribute, but figure I might ask about coordinating that effort first.

[tjhei]

I opened a PR this morning: spack/spack#48040

This adds the new versions. The errors you describe are about something else on your system.

[markyoder]

Ok, thanks. I'll wait for that PR. I'm not sure the other errors I get are best described as associated with "my system," since all of the dependencies are build in Spack, but I'll see how it goes with the new PR. I think all I really need is the v3.x re-up.