Skip to content

In pull-request, we should diff against ${{ github.event.pull_request.base.sha }} #18

Open
@praiskup

Description

Not against the (possibly updated) freshly checked-out origin/main branch.

This is the problem:

git fetch origin "$target_branch:$target_branch" &>/dev/null

The generated diff might be unnecessarily big if a different pull-request was merged in the meantime.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions