Skip to content

JSX & VS Code plugin: "wrap with abbreviation" fails with a quote #734

Open
@noahlt

Description

VSCode Emmet plugin fails to run Wrap with abbreviation in this case, maybe because it thinks that you’re trying to wrap attribute and quote makes this attribute invalid:

export default function Test() {
  return (
    <AbstractComponent
      render={() => {
        return (
          <p>example's</p>
        );
      }}
    />
  );
}

If you select the

element and try to run "wrap with abbreviation" inside VS code, it fails — doesn't even pop the "enter abbreviation" prompt. This seems to be due to the single quote, probably breaking Emmet's parser.

Note that this seems to interact with #733 somehow, because the following example has no problem:

function Foo() {
	return (
		<div>example's</div>
	)
}

Thanks for all your wonderful work on Emmet!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    ya-osnOpen-source Night Yandex event

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions