Skip to content

[Bug]: DNN 10 > Aperture Theme Footer styling is not specific enough #6399

Open
@Timo-Breumelhof

Description

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

I opened a page with the Community Forums on it and the footer of a topic picks up styling from the Theme.

Steps to reproduce?

  1. Place a module which has in internal footer element on a page
  2. Use the Aperture Theme.

Current Behavior

The internal module's header and footer pick up styling meant for the Theme

Image

Expected Behavior

The internal module's footer and header should not pickup Theme styling

I spotted 2 issues.

  1. The fact that there is styling for the header element makes internal headers sticky too
    https://github.com/dnnsoftware/Dnn.Platform/blob/release/10.0.0/DNN%20Platform/Skins/Aperture/src/scss/sections/_header.scss

  2. Internal footer pick up the background color of the Theme footer.
    https://github.com/dnnsoftware/Dnn.Platform/blob/release/10.0.0/DNN%20Platform/Skins/Aperture/src/scss/sections/_footer.scss

Anything else?

I suggest not to style on any general elements like header, footer etc. from the theme as that might lead to clashes with element in modules.

<header class="theme-header">

<footer class="theme-footer">

I what I tend to use to avoid this.

Affected Versions

10.0.0 (alpha)

What browsers are you seeing the problem on?

Firefox

Code of Conduct

  • I agree to follow this project's Code of Conduct

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions