[Bug]: Faulty MoveTabAfter and MoveTabBefore logic

[timi-ty]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

The procedures: MoveTabBefore and MoveTabAfter, in https://github.com/dnnsoftware/Dnn.Platform/blob/develop/DNN%20Platform/Website/Providers/DataProviders/SqlDataProvider/DotNetNuke.Data.SqlDataProvider do not work correctly in case several tabs (pages) of a parent have the same TabOrder value. It is then not possible to insert a tab into the series of pages with the same TabOrder value.

Steps to reproduce?

1. Go to the content tab on the admin panel
2. Click on 'Pages'
3. Create two or more pages with the same TabOrder value (change the TabOrder value within the database as this change cannot be performed explicitly from the UI)
4. Move a page of a different TabOrder value, between two pages of the same TabOrder value.
5. Refresh the site

Current Behavior

Home, 404 Error Page, Page One, and Page Two have the same TabOrder value. Attempting to move Activity Feed with a different TabOrder value, between them, fails.

The page with a different TabOrder value (Activity Feed) is moved above all tabs with the same TabOrder value.

Expected Behavior

Activity Feed should be in between 404 Error Page and Page One

Relevant log output

Anything else?

No response

Affected Versions

9.13.6 (latest release)

What browsers are you seeing the problem on?

Chrome, Microsoft Edge

Code of Conduct

• I agree to follow this project's Code of Conduct

[bdukes]

Do you know what caused you to get into a scenario where the TabOrder of multiple pages was the same? As you noted, there's not a UI that should allow you to get into that scenario.