Skip to content

Refactor/improve definition and use of TelescopeDescription and its string represenation #2675

Open
@maxnoe

Description

This also makes me wonder why we have the same string rep for different types in the first place, but good to fix. Really, the telescope type string was supposed to have three parts:

  • a high-level type name: LST/MST/SST
  • a optics name
  • a camera name
    When anything changes in the description, the optics or camera name should also be changed, i,e by adding a version, but we don't enforce that. The optics name should not in general be just "LST" (which is redundant), but rather something version-able or that describes better the current optics design. I would expect in the future we could have e.g. 1: LST_v1_LSTCam, 2,3,4: LST_v2_LSTCam, but that needs to be done at the simualtion production level when setting the metadata.

Originally posted by @kosack in #2673 (review)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    module:instrumentissues with the instrument description (ctapipe.instrument)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions