Skip to content

File watcher is not work perfectly with symlink #1946

Open
@invzhi

Description

I'm using git-sync and fava with docker-compose to share the ledger with my partner.

git-sync "publishes" each sync through a worktree and a named symlink to ensure an atomic update.
image

The problem is that when I update and push the ledger for the first time after the fava docker runs, fava can catch changes. But when I update and push the ledger again, fava cannot catch changes.
This means in my situation, fava can only catch changes for the first time.

I checked the code. Maybe the cause is fava only watches the absolute path of files.

files_set = {p.absolute() for p in files if p.exists()}
folders_set = {p.absolute() for p in folders if p.is_dir()}

BTW, I tried --poll-watcher option. It works.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions