What is the contributors table link based on?

[LPeter1997]

I don't really know what the bot inserts as a link for a given entry in the contributors table (I see that it's the "profile" link in the JSON). Many times it's their GitHub profile or a personal page. But recently it managed to insert an NSFW website with a similar link as the name of my contributors username. Can I make sure it's always the GitHub page instead?

[gr2m]

Can you link to the commit that made the change?

[LPeter1997]

Sure: LanguageDev/Yoakke@a7a64a3

After this, I'd much prefer a direct link to the GH profile instead of any custom homepage.

[gr2m]

I actually have no idea where this URL came from, I'd need to dig into the code myself and don't have the time right now. Maybe the user had furesoft.ml configured as their profile website and if the website is present, that's what the all-contributors app is using?

[wkillerud]

I was wondering the same thing here today, and I think I found it. github.js and its getUserInfo function automatically prefers the blog field over html_url if the former is a valid URL (GitHub API docs for Users). From what I can tell, the GitLab version only does profile links, not other websites (GitLab API docs for Users).

I would have expected these links to only ever point to the GitHub profile (html_url). As it is now, my avatar in fremtind/jokul links to a domain I'm no longer renewing. I did not expect to have to update the URL any other place than my GitHub profile.

My suggestion would be to change the CLI so that the profile field returned by getUserInfo() only ever returns html_url. For users who want the current behavior, the function could be expanded to also return a blog value which can behave like profile does today (fall back to html_url). That way they can use a custom contributorTemplate that uses contributor.blog instead of contributor.profile.