Skip to content

Improve bot error messaging on invalid commitType config (Example inside) #485

Open
@brandonlenz

Description

Describe the bug
When fed a valid request, the bot says it is unable to process the request:

trussworks/react-uswds#2618 (comment)

image

This was due to the repository config using a commitType that also included a scope. Reverting the scope fixed the issue:

image

trussworks/react-uswds#2653 (comment)

To Reproduce
Steps to reproduce the behavior:

  1. Create a repo with an all contributors config file that includes commitType: "chore(someScope)"
  2. Try to use the bot
  3. Note that it fails. The error sounds like it is network, API, or all-contributors code related. I suspect since it works for others (presumably) that there is actually an issue with our repo or configuration. Note that the bot used to work in this repo.

Expected behavior
The bot should properly create the contributor PR

OR

The bot should indicate what the problem is, in this case, specifically handling an error that I assume bubbles up from https://github.com/Berkmann18/commit-conv

Additional

Opened an issue with commit-conv: Berkmann18/commit-conv#35 to allow scope.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions