bug from "convertColorsToMDHighlight"

[kych]

Hi I think this parameter can convert the entire colored text line from Evernote to highlighted text line in MD, but NOT working for a part of colored text in a textline.

[github-actions]

Yihaa, thank you for reporting me this issue and to let me improve Yarle!

[nikithajain888]

Hi, I can fix this. Can you assign it to me?

[akosbalasko]

hi @nikithajain888 , sure thing, thanks a lot!

[kshunterco]

Thank you I just found this application and am here almost exclusively for this feature...

Actually I am hoping it does what it seems to say - keeps HTML color tags for color text - is that correct?

[akosbalasko]

hi @kshunterco , yeah, that would be the goal.

[kshunterco]

hi @kshunterco , yeah, that would be the goal.

Thanks for the quick response. I don't know TS at all but might be able to pick up enough to help. I have cloned the repository and am looking/grepping through the source but (sorry) I can't actually tell where the convertColorsToMDHighlight option is implemented. If you have time, could you please point me in the right direction and I'll... I'll maybe possibly do something LOLOL

[akosbalasko]

thanks for the offer @kshunterco , @nikithajain888 has already volunteered to implement it. Now I checked the code and the convertColorsToMDHighlight is applied in span-rule.ts, that is triggered whenever the converter finds a tag within the note coming from Evernote. The interesting point is that as far as I remember spans are not placed consistently in an Evernote note as far as I remember that's why convertColorsToMDHighlight is implemented by paragraph, not by inline text. But let's see, I hope @nikithajain888 can implement a much more sophisticated and smarter solution.