Skip to content

History lib doesn't account for some types of changes #679

Open
@klyap

Description

Problem:
I'm trying to use inspector with aframe-watcher to update my local files with changes I make with AFrame inspector. However, I noticed that some types of changes don't get written:

  1. Component is added or removed
  2. Entity is added or removed

Potential cause:
From my best understanding, the way it works is when a change in inspector happens, it fires an "entityupdate" event. This is listened to in the history.js file and recorded. When the save button is pressed, it makes a request to aframe-watcher with the contents of what has been recorded in AFRAME.INSPECTOR.history.updates.

It seems like the "entityupdate" event is not fired when these additions / removals are done in inspector.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions