Fixes #4069 : Ignore CSV inOutMode during OFX imports #4382

langelgjm · 2025-02-14T20:58:24Z

Fixes #4069 : Ignore CSV inOutMode during OFX imports

netlify · 2025-02-14T20:58:41Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`73972ca`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67b4ac397b4d910008d0a386
😎 Deploy Preview	https://deploy-preview-4382.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-02-14T20:59:54Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
17	6.93 MB → 6.93 MB (-277 B)	-0.00%

Changeset

File	Δ	Size
`node_modules/clsx/dist/clsx.mjs`	🆕 +368 B	0 B → 368 B
`node_modules/clsx/dist/clsx.mjs?commonjs-proxy`	🆕 +64 B	0 B → 64 B
`src/components/modals/ImportTransactionsModal/ImportTransactionsModal.jsx`	📈 +61 B (+0.20%)	30.19 kB → 30.25 kB
`node_modules/react-grid-layout/build/components/WidthProvider.js`	📈 +1 B (+0.02%)	5.22 kB → 5.22 kB
`node_modules/react-grid-layout/build/GridItem.js`	📈 +1 B (+0.00%)	21.49 kB → 21.49 kB
`node_modules/react-grid-layout/build/ReactGridLayout.js`	📈 +1 B (+0.00%)	24.96 kB → 24.96 kB
`node_modules/define-data-property/index.js`	📉 -9 B (-0.39%)	2.25 kB → 2.24 kB
`node_modules/call-bind/index.js`	📉 -9 B (-0.84%)	1.05 kB → 1.04 kB
`node_modules/has-property-descriptors/index.js`	📉 -9 B (-1.55%)	582 B → 573 B
`node_modules/es-define-property/index.js`	📉 -210 B (-37.50%)	560 B → 350 B
`node_modules/clsx/dist/clsx.js`	🔥 -509 B (-100%)	509 B → 0 B
`node_modules/clsx/dist/clsx.js?commonjs-module`	🔥 -27 B (-100%)	27 B → 0 B

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/ReportRouter.js	1.59 MB → 1.59 MB (+67 B)	+0.00%

Smaller

Asset	File Size	% Changed
static/js/index.js	4.31 MB → 4.31 MB (-344 B)	-0.01%

Unchanged

Asset	File Size	% Changed
static/js/en-GB.js	99.42 kB	0%
static/js/de.js	111.72 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/nl.js	98.54 kB	0%
static/js/en.js	100.54 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/uk.js	111.11 kB	0%
static/js/fr.js	71.59 kB	0%
static/js/pt-BR.js	106.43 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/AppliedFilters.js	10.52 kB	0%
static/js/useAccountPreviewTransactions.js	1.69 kB	0%
static/js/wide.js	102.8 kB	0%
static/js/narrow.js	85.57 kB	0%

github-actions · 2025-02-14T20:59:55Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.33 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.33 MB	0%

coderabbitai · 2025-02-14T21:17:10Z

Walkthrough

The changes modify the ImportTransactionsModal component in the ImportTransactionsModal.jsx file, specifically focusing on the handling of the inOutMode parameter. The getImportPreview and onImport functions have been updated to set inOutMode to false when processing OFX file types, using the conditional expression isOfxFile(filetype) ? false : inOutMode. This ensures that the inOutMode parameter is disregarded for OFX files, affecting how transaction amounts are processed during import. No alterations were made to the declarations of exported or public entities.

Possibly related PRs

make import button reflect accurate number of transactions to be added #3613: This PR modifies the logic for enabling the import button in the ImportTransactionsModal, indicating a direct relationship in their modifications to the same file.
♻️ split ImportTransactionsModal into smaller component files #3552: This PR involves splitting the ImportTransactionsModal into smaller components, which relates to the handling of the inOutMode parameter in the same component.
save csv inOutMode settings #3543: This PR updates the initialization of the inOutMode state variable, which is directly connected to the modifications made in the getImportPreview and onImport functions.

Suggested labels

:sparkles: Merged

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f066331 and 73972ca.

📒 Files selected for processing (1)

packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.jsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.jsx

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: build (macos-latest)
GitHub Check: build (windows-latest)
GitHub Check: test
GitHub Check: Wait for Netlify build to finish
GitHub Check: build (ubuntu-latest)
GitHub Check: Analyze

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

youngcw · 2025-02-17T20:11:36Z

Would it make sense to only use inoutmode when looking at CSV's? So invert the logic to only pass in the inOutMode when parsing a CSV? Is there any reason that a qif or qfx file needs that setting enabled?

langelgjm · 2025-02-18T18:45:51Z

Would it make sense to only use inoutmode when looking at CSV's? So invert the logic to only pass in the inOutMode when parsing a CSV? Is there any reason that a qif or qfx file needs that setting enabled?

Yes, as far as I can tell inOutMode only applies to CSVs as the OFX spec states that the sign of a value determines the direction of the flow of funds. It looks like #4069 might have been inadvertently introduced by #3543 which persisted the inOutMode preference across sessions.

Ignore inOutMode during OFX imports

2f0a625

actual-github-bot bot added the 🚧 WIP label Feb 14, 2025

Add release notes

f066331

langelgjm mentioned this pull request Feb 14, 2025

[Bug]: QFX amounts are lumped together in Amount column despite having distinct positive and negative values #4069

Closed

1 task

langelgjm changed the title ~~[WIP] Fixes #4069: Ignore CSV inOutMode during OFX imports~~ Fixes #4069: Ignore CSV inOutMode during OFX imports Feb 14, 2025

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Feb 14, 2025

langelgjm changed the title ~~Fixes #4069: Ignore CSV inOutMode during OFX imports~~ Fixes #4069 : Ignore CSV inOutMode during OFX imports Feb 14, 2025

Merge branch 'master' into ignore-csv-inoutmode-pref

73972ca

youngcw approved these changes Feb 18, 2025

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Feb 18, 2025

youngcw merged commit e86cbcd into actualbudget:master Feb 18, 2025
21 checks passed

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Feb 18, 2025

langelgjm deleted the ignore-csv-inoutmode-pref branch February 18, 2025 18:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #4069 : Ignore CSV inOutMode during OFX imports #4382

Fixes #4069 : Ignore CSV inOutMode during OFX imports #4382

langelgjm commented Feb 14, 2025 •

edited

Loading

netlify bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

coderabbitai bot commented Feb 14, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

youngcw commented Feb 17, 2025

langelgjm commented Feb 18, 2025

Fixes #4069 : Ignore CSV inOutMode during OFX imports #4382

Fixes #4069 : Ignore CSV inOutMode during OFX imports #4382

Conversation

langelgjm commented Feb 14, 2025 • edited Loading

netlify bot commented Feb 14, 2025 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Feb 14, 2025 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Feb 14, 2025 • edited Loading

Bundle Stats — loot-core

coderabbitai bot commented Feb 14, 2025 • edited Loading

Walkthrough

Possibly related PRs

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

youngcw commented Feb 17, 2025

langelgjm commented Feb 18, 2025

langelgjm commented Feb 14, 2025 •

edited

Loading

netlify bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

coderabbitai bot commented Feb 14, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)