GameSystemCollection.Remove doesn't remove item from underlying updateableGameSystems and drawableGameSystems lists

[guygodin]

The AddGameSystem call specifies a ProfilingKey as the KeyValuePair.Value while the Remove call specifies null as the value; therefore the item doesn't get removed.

xenko/sources/engine/SiliconStudio.Xenko.Games/GameSystemCollection.cs

Line 331 in 6fca455

var key = new KeyValuePair<IUpdateable, ProfilingKey>(updateableSystem, null);

xenko/sources/engine/SiliconStudio.Xenko.Games/GameSystemCollection.cs

Line 343 in 6fca455

var key = new KeyValuePair<IDrawable, ProfilingKey>(drawableSystem, null);

[Kryptos-FR]

First of all, congrats for the #666 issue 😈

Secondly, could you update the description and provide a link to the related file(s) in the sources?

[guygodin]

Woah wicked! Links added to issue.

[stefnotch]

More info regarding this issue:

The AddGameSystem call specifies a ProfilingKey as the KeyValuePair.Value

xenko/sources/engine/SiliconStudio.Xenko.Games/GameSystemCollection.cs

Line 390 in 6fca455

gameSystemKey = new KeyValuePair<T, ProfilingKey>(gameSystemKey.Key, new ProfilingKey(parentProfilingKey, gameSystem.GetType().Name));

Also, according to this answer, "[A KeyValuePair] is a struct. This means it uses the default value equality. This simply compares the values of the fields to test for equality." So, this is almost certainly a bug.

Lastly,updateableGameSystems is a normal C# list instead of a seemingly more fitting dictionary?

[guygodin]

It should be a list since it is iterated over a lot (iterating over lists performs better than dictionaries). The solution is to iterate over the items of the list in the Remove method and check for KeyValuePair.Key equality like it’s done elsewhere in my opinion.