Open
Description
I have updated rubocop-shopify
to 2.11.1
and fixing the layout with bundle exec rubocop -A
produced some weird changes.
The code before:
def collection
Service.not_deleted.includes(
{ vault_teams:
[:github_team_vault_teams, :teams] },
{ app:
[{ runtimes:
[:runtime_instances, :app] },
:runtimes,
:repo,] },
:repo,
:app,
:monorepo_mobile_app,
:bugsnag_project,
:slack_channels,
:vault_teams,
:vault_users,
).joins(:app)
end
The code after:
def collection
Service.not_deleted.includes(
{
vault_teams:
[:github_team_vault_teams, :teams],
},
{
app:
[
{
runtimes:
[:runtime_instances, :app],
},
:runtimes,
:repo,
],
},
:repo,
:app,
:monorepo_mobile_app,
:bugsnag_project,
:slack_channels,
:vault_teams,
:vault_users,
).joins(:app)
end
There are more extreme examples in this file.
It seems the problem doesn't happen if the opening bracket (or whole entry) is on the same line:
Before
def collection
Service.not_deleted.includes(
{ vault_teams:[:github_team_vault_teams, :teams] },
{ app:[
{ runtimes: [:runtime_instances, :app] },
:runtimes,
:repo,] },
:repo,
:app,
:monorepo_mobile_app,
:bugsnag_project,
:slack_channels,
:vault_teams,
:vault_users,
).joins(:app)
end
After
def collection
Service.not_deleted.includes(
{ vault_teams: [:github_team_vault_teams, :teams] },
{
app: [
{ runtimes: [:runtime_instances, :app] },
:runtimes,
:repo,
],
},
:repo,
:app,
:monorepo_mobile_app,
:bugsnag_project,
:slack_channels,
:vault_teams,
:vault_users,
).joins(:app)
end
Metadata
Assignees
Labels
No labels
Activity