Skip to content

get_current_git_hash breaks when using Jakt as a submodule #1490

Open
@aslilac

Description

For example, say you've added Jakt as a submodule to a folder named vendor/jakt/

  • If you ls vendor/jakt/.git you'll see it's actually just a regular file, not a directory.
  • If you cat vendor/jakt/.git you'll see something like...
$ cat vendor/jakt/.git
gitdir: ../../.git/modules/Jakt

So instead of reading "../.git/HEAD", it should actually be reading "../../../.git/modules/Jakt/HEAD".

Similarly, a bit later in the function, instead of "../.git/", the path should be "../../../.git/modules/Jakt/".

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions