Skip to content

Do not add import bounds #29

Open
Open
@orlp

Description

The pyo3_built macro adds an import bound for email.utils to parse a string date into a datetime, which seems really unnecessary to me. It adds a significant amount of import time to our library.

    ($py: ident, $info: ident, $dict: ident, "time") => {
        let dt = $py
            .import_bound("email.utils")?
            .call_method1("parsedate_to_datetime", ($info::BUILT_TIME_UTC,))?;
        $dict.set_item("info-time", dt)?;
    };

Even parsing the date in Rust and importing datetime to generate a Datetime object directly (while significantly better) seems unnecessary, although that would be a backwards-compatible.

My suggestion would be to replace the info-time field with a ISO 8601 timestamp string that we generate on the Rust side. Then if a user really wants a Datetime they can just datetime.datetime.fromisoformat the string.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions