Skip to content

Warn users that the default manylinux of auto may cause build failures #278

Open
@sxlijin

Description

Hi - we just found out that because the default manylinux selected is 2014, this has a strong likelihood of causing a build failure if your library has rustls as a dependency.

Specifically, the ring crate does not compile with gcc-4.8.0 on arm64-linux: briansmith/ring#1728

Our dependency on ring is implicit/transitive via rustls:

❯ cargo tree -i -p ring
ring v0.17.8
├── aws-config v1.5.3
│   └── baml-runtime v0.46.0 (/Users/sam/baml/engine/baml-runtime)
│       ├── baml v0.46.0 (/Users/sam/baml/engine/baml-cli)
│       ├── baml-python-ffi v0.1.0 (/Users/sam/baml/engine/language_client_python)
│       ├── baml-schema-build v0.46.0 (/Users/sam/baml/engine/baml-schema-wasm)
│       ├── baml-typescript-ffi v0.0.1 (/Users/sam/baml/engine/language_client_typescript)
│       └── ruby_ffi v0.1.0 (/Users/sam/baml/engine/language_client_ruby/ext/ruby_ffi)
├── rustls v0.21.12
│   ├── aws-smithy-runtime v1.6.0
│   │   ├── aws-config v1.5.3 (*)
│   │   ├── aws-sdk-bedrockruntime v1.37.0
│   │   │   └── baml-runtime v0.46.0 (/Users/sam/baml/engine/baml-runtime) (*)
│   │   ├── aws-sdk-sso v1.33.0
│   │   │   └── aws-config v1.5.3 (*)
│   │   ├── aws-sdk-ssooidc v1.34.0
│   │   │   └── aws-config v1.5.3 (*)
│   │   ├── aws-sdk-sts v1.33.0
│   │   │   └── aws-config v1.5.3 (*)
│   │   └── baml-runtime v0.46.0 (/Users/sam/baml/engine/baml-runtime) (*)
│   ├── hyper-rustls v0.24.2
│   │   ├── aws-smithy-runtime v1.6.0 (*)
│   │   └── reqwest v0.11.27
│   │       ├── baml v0.46.0 (/Users/sam/baml/engine/baml-cli)
│   │       └── check-latest v1.0.2
│   │           └── baml v0.46.0 (/Users/sam/baml/engine/baml-cli)
│   ├── reqwest v0.11.27 (*)
│   └── tokio-rustls v0.24.1
│       ├── hyper-rustls v0.24.2 (*)
│       └── reqwest v0.11.27 (*)
├── rustls-webpki v0.101.7
│   └── rustls v0.21.12 (*)
└── sct v0.7.1
    └── rustls v0.21.12 (*)

Took a solid hour+ of detective work to understand all the error messages we were getting and to track down the root cause correctly, so I wanted to flag this for your attention. It's clear that you've put a lot of work into making maturin cross-compilation Just Work out of the box, and this appears to stick a very frustrating wrench in that seamless experience.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions