Please restore versioned ArangoDB package(s)

[pvgoran]

Until 45dd4a1, nixpkgs had versioned package attributes: arangodb_3_3, arangodb_3_4, arangodb_3_5, arangodb_3_9, as well as the generic package attribute arangodb which points to arangodb_3_9. After this commit, versioned package attributes are gone, and only arangodb remains (which points to version 3.9.x).

It would be good to have versioned package attributes here, even if it only one version is included. This allows to safeguard against sudden version changes by specifying a versioned package in configuration, so that an administrator would have to notice a version change and then possibly take necessary actions (read upgrade instructions, backup/restore, or something).

I'm especially concerned about this because previously I encountered breakages in an existing database when performing in-place upgrade of ArangoDB.

[edited to fix improper markup and replace it with Markdown]

[pvgoran]

ping @jsoo1

[jsoo1]

I suppose we could make an alias to the current version but I can't commit to maintaining multiple versions.

[pvgoran]

I suppose we could make an alias to the current version but I can't commit to maintaining multiple versions.

An alias would resolve my main concern here.

(Although technically it ought to be the other way around: arangodb_3_9 being a primary attribute defined in arangodb/default.nix, and arangodb being an alias to arangodb_3_9. So that it would be impossible to forget updating a version in all-packages.nix when updating it in arangodb/default.nix.)

[edited to fix improper markup and replace it with Markdown]

[jsoo1]

Does #255012 address your problem @pvgoran ?

[pvgoran]

Does #255012 address your problem @pvgoran ?

Yes, it definitely does.

(However, I think it would be more clear and reliable if arangodb/default.nix returned an attribute set like { arangodb_3_10 = ...; } instead of just returning a package, similarly to how it worked before 45dd4a1. Additionally, if version is in a separate variable, then sha256 should probably be in a separate variable, too. I can try to prepare my own version of this commit, if it will make things easier for you.)

[jsoo1]

Sure! That would be lovely! Thank you!

[pvgoran]

@jsoo1 I created my own version at https://github.com/pvgoran/nixpkgs/commits/arango-versioned , please review and use these changes if you are OK with them.

The updateScript stuff gave me some doubts. The standard updaters (such as gitUpdater) update to a latest version, even if it's a next major or minor version. However, such update would make a versioned attribute like arangodb_3_10 point to a wrong version (such as 3.11.x), and a maintainer would have to notice such change and make necessary corrections. The update script that I put together only updates within the given major.minor.* versions (for example, from 3.10.5.2 to 3.10.10). This way, a maintainer would need to monitor the upstream for new minor versions and add them (semi-)manually, but this doesn't sound that bad to me.

[jsoo1]

@jsoo1 I created my own version at https://github.com/pvgoran/nixpkgs/commits/arango-versioned , please review and use these changes if you are OK with them.

The updateScript stuff gave me some doubts. The standard updaters (such as gitUpdater) update to a latest version, even if it's a next major or minor version. However, such update would make a versioned attribute like arangodb_3_10 point to a wrong version (such as 3.11.x), and a maintainer would have to notice such change and make necessary corrections. The update script that I put together only updates within the given major.minor.* versions (for example, from 3.10.5.2 to 3.10.10). This way, a maintainer would need to monitor the upstream for new minor versions and add them (semi-)manually, but this doesn't sound that bad to me.

Great catch on the updateScript! I'll check it out and apply your changes.

[pvgoran]

@jsoo1 Any luck with reviewing and applying this?

[jsoo1]

@pvgoran Thanks for the ping! I will take a look this week!

[jsoo1]

Just an update - I've been very busy but I hope to look at it this weekend. Thank you for your patience.

[jsoo1]

Hey @pvgoran I looked at your patch and I'm not sure it buys us enough, especially since I don't think we'll ever have more than one version in nixpkgs (that I maintain, at least).

The update script, though, I like! We ought have one for arangodb!