Fine-grained access-tokens #12465
Open
Fine-grained access-tokens #12465
+151
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
fetching
edolstra
approved these changes
Feb 13, 2025
edolstra
reviewed
Feb 13, 2025
edolstra
reviewed
Feb 13, 2025
| if(! url.empty()) { | ||
| for (auto & token : tokens) { | ||
| auto first = url.find(token.first); | ||
| if ( |
There was a problem hiding this comment.
Does this still work? If url is e.g. https://github.com/..., then it won't match with a token for github.com anymore, right? You may need to use parseURL() to get rid of the scheme part of the URL.
There was a problem hiding this comment.
Perhaps that is a misnomer. The "url" is made here: https://github.com/NixOS/nix/pull/12465/files#diff-be2f63dc22d73bd86ee70820979ee54ff2bb5cef76e3bbb53a673fddfd2a1b5cR211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support fine-grained tokens, multiple tokens per host.
Context
Supports:
Fixes: #8474