LocalStore does not set up or sanitize its build environment correctly

[roberth]

Describe the bug

When running a NixOS VM test on darwin, it only works when going through the daemon.

See

Steps To Reproduce

1. Get a shell on an aarch64-darwin machine
2. sudo nix build -vvvvL 'github:NixOS/nixpkgs?rev=f17d1f9302326b1bddb79ae37014bc5c1a104998#tests.testers.nixosTest-example'
   • observe failure
3. sudo env NIX_REMOTE=daemon nix build -vvvvL 'github:NixOS/nixpkgs?rev=f17d1f9302326b1bddb79ae37014bc5c1a104998#tests.testers.nixosTest-example'
   • observe success

Expected behavior

A clear and concise description of what you expected to happen.

nix-env --version output

nix-env --version                                                                                                                                                                                                                                                                                                ~
nix-env (Nix) 2.17.0

(yikes??, will try newer)

Additional context

• Discovered in NixOS Integration tests: Re-enable for macOS nixpkgs#303597 (comment)
• Non-solution (IMO) Don't have root bypass the daemon by default #10140

Priorities

Add 👍 to issues you find important.

[cole-h]

(nit: I think you mis-wrote the invocation with NIX_REMOTE -- probably meant sudo env NIX_REMOTE=daemon nix build instead of sudo nix build env NIX_REMOTE=daemon 😆 )

[roberth]

Thanks for the fix @cole-h, I'd reassambled the command because I was using a .drv path originally, which would be annoying to get. I've applied it. Thanks!

[fricklerhandwerk]

Triaged in Nix maintainers meeting:

• good issue, needs investigation to untangle the code path involved, help appreciated
• @fricklerhandwerk tangent: we may want to further discuss having a "bootstrap" Nix that only has the local store without a deamon and then builds the full Nix, as discussed with @roberth @RaitoBezarius @infinisil in the past

[nixos-discourse]

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-05-29-nix-team-meeting-minutes-148/46195/1