Skip to content

JVM: merge manifests of shaded libraries instead of overwriting them when packing benchmarks jar #274

Open
@fzhinkin

Description

Currently, JVM's Jar task responsible for generating executable benchmarks jar generates a brand new manifest that includes only a main-class attribute.

Depending on shaded libraries, that might be an issue. For example, if one of the libraries bundled into a resulting jar was a MR-JAR, the resulting manifest will be missing multi-release: true attribute and target-specific code will never be invoked (and that's a problem if you're actually trying to benchmark MR-related functionality ;) ).

It would be nice to merge manifests when generating a jar, like Maven Shade's AppendingTransformer does.

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions