Skip to content

TASK: Clean up permissions checking with Role Names vs. Role IDs #950

Open
@johnhenley

Description

There are a number of places in the module where permissions are checked, and sometimes use Role names vs IDs. Since these are both represented as string arrays internally, the conversion is not inherently obvious, leading to subtle bugs, and should be standardized across the module to always use one convention. Particularly in web api controllers security which inherits from DnnApiController, UserInfo.Roles returns NAMES, and needs to be converted to IDs to be passed to Forums PermissionController(). Review all and figure out a standard.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

technical debtIssue that doesn't directly affect usability but will improve technical debt posture

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions